fix: SKILZ-64 and SKILZ-65 Bug Fixes - Temp Directory Warnings & --config Flag #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 SKILZ-64 and SKILZ-65 Bug Fixes
Overview
Complete fix for two critical bugs affecting Skilz v1.7.0 user experience:
Changes Made
🔧 Code Changes
config_fileparameter toinstall_from_git()function🧪 Testing Added
�[0;34m[INFO]�[0m These tests should FAIL initially, then PASS after fixes
�[0;34m[INFO]�[0m Setting up test environment...
�[0;34m[INFO]�[0m Test environment ready: /tmp/skilz-bug-test-1767989454
�[0;34m[INFO]�[0m Testing BUG 1: SKILZ-64 - Temp Directory Warnings
�[0;34m[INFO]�[0m Testing Bug 1: Git installs should not warn about temp directories
�[0;32m[PASS]�[0m BUG1_GIT_NO_TEMP_WARNING: No temp directory warnings found** - Comprehensive E2E test suite
5. **** - Unit tests with proper mocking
📚 Documentation Updated
Bug Details
SKILZ-64: Temp Directory Warning During Git Installs
Problem: Git installs showed confusing warnings about temp directory names
Fix: Skip directory validation when
git_urlis provided (temp directories)Result: No false warnings during successful git installations
SKILZ-65: --config Flag Not Working for Git Installs
Problem:
--config FILENAME.mdignored for git URL installationsFix: Added config_file parameter support throughout git install pipeline
Result: --config flag works consistently across all install types
Testing Strategy
TDD Approach
Test Coverage
Quality Assurance
Success Criteria Met
Related Issues
Closes SKILZ-64, SKILZ-65
Testing
Run the comprehensive test suite:
Impact